Skip to content

refactor: treat empty expandable arrays as non expandable (fixes SFKUI-7728)#1094

Merged
jensviklander merged 3 commits intomainfrom
empty-expandable-row
Mar 11, 2026
Merged

refactor: treat empty expandable arrays as non expandable (fixes SFKUI-7728)#1094
jensviklander merged 3 commits intomainfrom
empty-expandable-row

Conversation

@jensviklander
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Artifact sizes

Artifact sizes in this build (unchanged artifacts collapsed below).

Artifact Files Size Change
@fkui/vue-labs (esm) 1 file(s) 248.8KiB → 248.8KiB (+54B) +0.02%
7 unchanged artifacts
Artifact Files Size
@fkui/date (esm) 1 file(s) 32.2KiB
@fkui/design 2 file(s) 189.8KiB
@fkui/logic (esm) 1 file(s) 162.3KiB
@fkui/vue (esm) 1 file(s) 1.1MiB
@fkui/vue (FBadge bundle) 1 file(s) 550.5KiB
@fkui/vue/cypress 1 file(s) 56.0KiB
@fkui/vue/selectors 1 file(s) 3.3KiB

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Förhandsgranskning 🐛 🔍

Dokumentation och exampel applikationer finns att förhandsgranska på:

Sida URL
Dokumentation https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1094/
Vue Sandbox https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1094/vue-sandbox
Applikationsmall https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1094/examples/page-layout

Senast uppdaterad 2026-03-11 14:25 UTC i gh-pages.

@github-actions
Copy link

CHANGELOG

No commits contributing to a release was found, no changelog entries will be added for this Pull Request.

If this PR should be included in a release amend the commit message(s) to use:

  • fix: for a patch version or
  • feat: for minor version.

Read more about the release process (swedish).

expandableAttribute && row[expandableAttribute],
);
const isExpandable =
!!expandableAttribute &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jag har pendlat över till Boolean() då det är mer explicit. Vet inte vad andra tycker. Nitpick :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tycker vi kör på Boolean() då vi använder det överallt annars och som du säger så är det mer explicit 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jag håller med, jag trodde faktiskt vi hade lint-regel för det tom. !! är väldigt magiskt och konstigt första gången man stöter på det

Copy link
Contributor

@atfkassan atfkassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testat

@jensviklander jensviklander merged commit 4e1e6a0 into main Mar 11, 2026
28 checks passed
@jensviklander jensviklander deleted the empty-expandable-row branch March 11, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants