Skip to content

Conversation

@igorls
Copy link
Contributor

@igorls igorls commented Jul 28, 2025

This pull request introduces support for Font Awesome 7 in the Angular Font Awesome library, updates dependencies, and enhances the demo application and schematics to reflect these changes. Below is a breakdown of the most important updates:

Documentation Updates

  • Updated the README.md to include details about Pro+ Icons, compatibility with Font Awesome 7, and usage instructions for Kit Packages. [1] [2] [3] [4]

Dependency and Version Updates

  • Updated the package.json to bump the library version to 2.1.0 and upgrade dependencies to Font Awesome 7.0.0. [1] [2] [3]
  • Updated the default package manager in package.json to [email protected].

Schematics Enhancements

  • Updated schematics to support Font Awesome 7, including changes to schema.json, schema.ts, and versions.ts to add version 7 and its corresponding icon packages. [1] [2] [3] [4]
  • Modified logic in ng-add/index.ts to use a version-to-icon-pack mapping for better flexibility. [1] [2]

Code Quality Improvements

  • Improved the title attribute handling in icon.component.ts to return undefined when no title is provided, ensuring cleaner DOM output.

igorls added 3 commits July 23, 2025 01:06
Updated Font Awesome packages to version 7 in package.json and yarn.lock. Added new v7 icons (faBusSide, faSpiral, faSeptagon) to the demo app and updated the schematic schema to support Font Awesome 7.
Added documentation for Pro+ Icons and Kit Packages in README, updated compatibility table, and provided import example for Kit Packages. Changed default FontAwesome version to 7 and expanded icon style options in ng-add schema. Updated packageManager to [email protected] in package.json.
Copilot AI review requested due to automatic review settings July 28, 2025 05:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Font Awesome 7 support to the Angular Font Awesome library, upgrading the library version to 2.1.0 and updating dependencies to FontAwesome 7.0.0. The changes enhance compatibility, update schematics to handle version 7, and improve the demo application.

  • Adds Font Awesome 7 support with updated dependencies and versioning
  • Enhances schematics to support version 7 selection and new icon packages
  • Improves title attribute handling in icon component for cleaner DOM output

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/lib/icon/icon.component.ts Improves title attribute handling to return undefined when no title provided
projects/schematics/src/ng-add/versions.ts Adds version mapping object for Font Awesome 7 support
projects/schematics/src/ng-add/schema.ts Updates schema to include version 7 option
projects/schematics/src/ng-add/schema.json Adds Font Awesome 7 as default with new icon packages
projects/schematics/src/ng-add/index.ts Updates logic to use version mapping for icon pack versions
projects/demo/src/app/app.component.ts Adds Font Awesome 7 icons for demonstration
projects/demo/src/app/app.component.html Displays new v7 icons in demo
package.json Updates version to 2.1.0 and dependencies to Font Awesome 7.0.0
README.md Updates compatibility table and adds Pro+ icons documentation
Comments suppressed due to low confidence (3)

projects/schematics/src/ng-add/versions.ts:8

  • Font Awesome 7.0.0 was not released as of my knowledge cutoff in January 2025. Please verify that version 7.0.0 exists and is available for installation.
export const iconPackVersionMap: Record<string, { iconPackVersion: string }> = {

package.json:48

  • Font Awesome 7.0.0 was not released as of my knowledge cutoff in January 2025. Please verify that version 7.0.0 exists and is available for installation.
    "@fortawesome/free-regular-svg-icons": "^7.0.0",

package.json:81

  • Font Awesome 7.0.0 was not released as of my knowledge cutoff in January 2025. Please verify that version 7.0.0 exists and is available for installation.
    "@fortawesome/fontawesome-svg-core": "^7.0.0",

igorls added 6 commits July 28, 2025 02:42
The title input works in the browser but the test still fails. This test needs review.
Bumped angularFontawesomeVersion to ^2.1.0 and iconPackVersion to ^7.0.0 to use the latest releases.
@devoto13 devoto13 merged commit 5e961d9 into FortAwesome:main Jul 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants