chore(icon): remove required constraint on icon input to support dyna… #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoto13
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 2.0.1, the
iconinput onfa-iconwas marked as required using Angular'smodel.required().This PR makes the
iconinput optional again, to support use cases where the icon is assigned dynamically via a custom directive or service at runtime. These patterns are useful for maintaining clean templates and centralizing icon configuration.Since the library already provides a runtime check (
faWarnIfIconSpecMissing()), compile-time enforcement may be overly restrictive for some scenarios.This change restores flexibility while maintaining runtime safety.
Let me know if you'd prefer a different approach or additional test coverage. Happy to adjust as needed!
Closes #475