Convert most FontAwesome elements to self-closing tags #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoto13
force-pushed
the
self-closing-tags
branch
from
c22857e to
26a27a0
Compare
devoto13
approved these changes
Aug 3, 2025
Collaborator
devoto13
left a comment
devoto13
left a comment
There was a problem hiding this comment.
Looks neat!
Thank you for the contribution :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-closing tags have been supported since Angular 16 and improve readability when Angular components without content are used inside a template.
Since most FontAwesome components do not support content projection, there's no use for the space between the opening and closing tags of the elements.
<fa-icon [icon]="faCoffee"></fa-icon>-><fa-icon [icon]="faCoffee" />Using the self-closing tag on
<fa-icon />clearly communicates that the element doesn't expect any content between the opening and closing tags.This PR changes most the documentation and examples to use the self-closing tags.
The only files I left as-is are all but the latest file in the
upgrading/folder, since those can be referenced with Angular versions below 16.