Helper#icon prepends fa- to given fa class string

[nnattawat]

I made the improvement on the helper method. Now it can handle multiple fa- classes.

For example, to add fa-2x class we need to use icon('flag', class='fa-2x') which make more sense to use it as the following.

icon('flag 2x')
# => <i class="fa fa-flag fa-2x"></i>

[houndci-bot]

Shadowing outer local variable - icon.

[nnattawat]

What do you mean?

[houndci-bot]

Shadowing outer local variable - icon.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

[houndci-bot]

Line is too long. [81/80]

[nnattawat]

I think it's not that long haha :)

[nickpearson]

You should probably call to_s on icon before trying to split it. Before this change, a Symbol could be passed in, but now it requires a String, potentially causing existing usages to break.

[andreykul]

How about optional array instead?

icon([:flag, '2x', :fw], "Big Flag")
# => <i class="fa fa-flag fa-2x fa-fw"></i>

icon(:flag, 'Normal flag')
# => <i class="fa fa-flag"></i>

[houndci-bot]

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

[nnattawat]

@nickpearson and @andreykul good points guys. I have made it to support more formats.

icon(:flag)
# => <i class="fa fa-flag">

icon('flag')
# => <i class="fa fa-flag">

icon([:flag, :fw, '2x'])
# => <i class="fa fa-flag fa-fw fa-2x">

icon("flag fw 2x")
# => <i class="fa fa-flag fa-fw fa-2x">