Use parse only if not an icon object #327
Open
+95
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonlundien
reviewed
Sep 7, 2021
| @@ -33,7 +37,7 @@ if(coreHasFeature(ICON_ALIASES)) { | |||
| const vm = mountFromProps({ icon: ['fas', 'close'] }) | |||
|
|
|||
| expect(vm.$el.tagName).toBe('svg') | |||
| expect(vm.$el.classList.contains('fa-close')).toBeTruthy() | |||
| expect(vm.$el.classList.contains('fa-xmark')).toBeTruthy() | |||
There was a problem hiding this comment.
did you want the fa-xmark icon here?
In v6 xmark is the name of the icon and close is the alias.
If we keep the fa-mark we will need to import it (line 4), and will probably want to change the test name; currently test is 'find a free-solid-svg-icon that is an alias'.
As of right now, the test mentioned on the previous line fails because xmark has NOT been imported.
jasonlundien
reviewed
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.