Skip to content

Conversation

alexoutsold
Copy link
Contributor

No description provided.

@Sophilautia
Copy link
Contributor

Sophilautia commented Jul 18, 2024

Hi @alexoutsold

Please complete the board submission form here: https://forms.gle/E1fwdGCHuAxhDLPr9

You will need to upload the background and music to google drive in a zip, the background files (except the map icon) will need to be removed from your Pull Request.

@Sophilautia
Copy link
Contributor

Also noticed these errors in the validation:

Additional properties are not allowed ('capitalShopNames' was unexpected)
YAML files shall no longer contain the line '---' or '...'

@Ennesan
Copy link
Contributor

Ennesan commented Aug 24, 2024

There are no authors listed in the Onion.YAML file.

@Sophilautia
Copy link
Contributor

Right, @alexoutsold this needs a couple of changes.

  1. Yaml needs author section
  2. Yaml needs changelog section
  3. Max Dice Roll is set to 7, but Venture Card 87 is enabled. Venture Card 87 makes the player roll either a 7 or an 8, which can work, but can also cause issues since this value being higher than the Max Dice Roll makes it very hard to test pathing for. Please either change the max dice roll to 8 or change Venture Card 87 to something else.

Copy link
Contributor

@Ennesan Ennesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing one activated Venture Card due to having deactivated Venture Card 87. Please add one more venture card to be activated.

@Ennesan
Copy link
Contributor

Ennesan commented Oct 20, 2024

スクリーンショット 2024-10-20 144947
The points noted above correspond to the red line in this image.

@Sophilautia Sophilautia merged commit 62144b9 into FortuneStreetModding:main Jan 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants