-
Notifications
You must be signed in to change notification settings - Fork 46
New map: StarshipRedux #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New Board: Starship Redux
new map: Starship Redux
Please remove "StarShip Mario.yaml" from your pull request, I'm assumning that file wasn't meant to be uploaded. |
Okay, it's passing the github check now. Could you please fill out our board submission form for this board: |
Okay, I've noticed a few issues.
Also went and looked at your MidgarT background, and I've decided that it needs a bit more work before it's ready to be included in CSWT, so I removed it from your PR for now. |
Still waiting on @FatCat67 to fix the music here |
whats up with the music??? if its about the 2nd link ive never done that
myself so idk where to get that from, if there's another issue ill fix it
…On Tue, 3 Sept 2024 at 09:39, Sophilautia ***@***.***> wrote:
Still waiting on @FatCat67 <https://github.com/FatCat67> to fix the music
here
—
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVKU4CQ67CVBVAEUXMVHHM3ZUVYSZAVCNFSM6AAAAABLBEXWUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVHEZDSMBYHE>
.
You are receiving this because you were mentioned.Message ID:
<FortuneStreetModding/fortunestreetmodding.github.io/pull/227/c2325929089@
github.com>
|
@FatCat67 The link to the music download in the yaml (https://drive.google.com/uc?export=download&id=1C24uC2iPDPojTfbJA8iO0LtuTjp17k_I) links to Delfino Redux music. I don't have a link to the music of this board. |
just fixed that, my bad
…On Tue, 10 Sept 2024 at 03:50, Sophilautia ***@***.***> wrote:
@FatCat67 <https://github.com/FatCat67> The link to the music download in
the yaml (
https://drive.google.com/uc?export=download&id=1C24uC2iPDPojTfbJA8iO0LtuTjp17k_I)
links to Delfino Redux music. I don't have a link to the music of this
board.
—
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVKU4CTMMSENQ4VVDZMEWXDZVZM5XAVCNFSM6AAAAABLBEXWUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGUYDGOJWGY>
.
You are receiving this because you were mentioned.Message ID:
<FortuneStreetModding/fortunestreetmodding.github.io/pull/227/c2339503966@
github.com>
|
Thanks for that. I checked the music and the sample rate was higher than 32k, so I've reduced the sample rate for the tracks and uploaded them to the server. Please make sure to use 32k music in the future! |
I did a verification and found some more issues. Sorry for the trouble.
I went and addressed 1-3 by adding a changelog section, defining the mapIcon, and adding an author section attributing the board to FatCat67. If you'd like to add a URL for your attribution please let me know. As for point 4 though, this will need your input on which venture card you'd like to replace 87 with. |
No description provided.