Skip to content

Conversation

FatCat67
Copy link
Contributor

No description provided.

@Sophilautia
Copy link
Contributor

Please remove "StarShip Mario.yaml" from your pull request, I'm assumning that file wasn't meant to be uploaded.

@Sophilautia
Copy link
Contributor

Sophilautia commented Jul 23, 2024

Okay, it's passing the github check now.

Could you please fill out our board submission form for this board:

https://forms.gle/yzqiYrQ4Munc44Lo7

@Sophilautia
Copy link
Contributor

Sophilautia commented Jul 26, 2024

Okay, I've noticed a few issues.

  1. The Title and Description of your board included superfluous languages that you didn't edit, so I removed them
  2. I tidied up the formatting of the description to match the template
  3. The music download you linked to is DelfinoRedux's music, it seems like you made a mistake here and will need to fix it

Also went and looked at your MidgarT background, and I've decided that it needs a bit more work before it's ready to be included in CSWT, so I removed it from your PR for now.

@Sophilautia
Copy link
Contributor

Still waiting on @FatCat67 to fix the music here

@FatCat67
Copy link
Contributor Author

FatCat67 commented Sep 9, 2024 via email

@Sophilautia
Copy link
Contributor

@FatCat67 The link to the music download in the yaml (https://drive.google.com/uc?export=download&id=1C24uC2iPDPojTfbJA8iO0LtuTjp17k_I) links to Delfino Redux music. I don't have a link to the music of this board.

@FatCat67
Copy link
Contributor Author

FatCat67 commented Sep 13, 2024 via email

@Sophilautia
Copy link
Contributor

Thanks for that.

I checked the music and the sample rate was higher than 32k, so I've reduced the sample rate for the tracks and uploaded them to the server. Please make sure to use 32k music in the future!

@Sophilautia
Copy link
Contributor

Sophilautia commented Oct 20, 2024

@FatCat67

I did a verification and found some more issues. Sorry for the trouble.

  1. An author isn't specified in the yaml
  2. A changelog isn't specified in the yaml
  3. The yaml doesn't define a mapIcon
  4. Max Dice Roll is set to 6, but Venture Card 87 is enabled.

I went and addressed 1-3 by adding a changelog section, defining the mapIcon, and adding an author section attributing the board to FatCat67. If you'd like to add a URL for your attribution please let me know.

As for point 4 though, this will need your input on which venture card you'd like to replace 87 with.

@Sophilautia Sophilautia merged commit b266b38 into FortuneStreetModding:main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants