Skip to content

Conversation

@curbengh
Copy link
Contributor

@curbengh curbengh commented Nov 16, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Add solar term to holiday list.
  • Exported from apple calendar which includes solar term when showing china holidays.
  • It's a list of astronomical events, not public holiday, so a bit of novelty.
  • I set all events as recurring, even though some dates may change every year. The dates are correct until 2025/11/22, if apple is correct until then. I'm assuming importing newer version of solarterm.ics will replace previously imported events with the same UID.
  • Traditional chinese characters are used as they are similar enough (though not exactly the same) to japanese kanji and korean hanja, at least until the holiday feature support internationalization.

Acknowledgement

@naveensingh
Copy link
Member

naveensingh commented Jan 18, 2025

Exported from apple calendar which includes solar term when showing china holidays.

Was it a separate option or just included with the holidays?

I'm asking because of this:

It's a list of astronomical events, not public holiday

@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Jan 19, 2025
@fossifybot-legacy
Copy link
Member

This pull request has been automatically closed due to inactivity. We requested additional information but have not received a response from the original author. Without the requested details, we cannot proceed. If you have the needed information or updates, please reopen the PR or comment so we can continue the review.

@Aga-C Aga-C removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants