Skip to content

Conversation

@curbengh
Copy link
Contributor

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

Acknowledgement

@tswistak
Copy link
Contributor

IMHO, you should rather modify the generator (https://github.com/FossifyOrg/Calendar/tree/master/.github/workflows/holiday-generator) to also consider regional holidays, not add them manually. They will get lost when the generator runs next time.

Another thing, as @naveensingh said in his comment (#173 (comment)):

Let's wait for some user feedback before making any further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants