Skip to content

Fixed reverting old filtering on quick filter long press#456

Merged
naveensingh merged 1 commit intoFossifyOrg:masterfrom
Aga-C:fix-quick-filter-long-press
Jan 28, 2025
Merged

Fixed reverting old filtering on quick filter long press#456
naveensingh merged 1 commit intoFossifyOrg:masterfrom
Aga-C:fix-quick-filter-long-press

Conversation

@Aga-C
Copy link
Contributor

@Aga-C Aga-C commented Jan 28, 2025

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Long press feature added in Added filtering single event type on long press (#309) #314 isn't reverting event types that aren't shown on the quick filter bar.
  • This PR fixes it - on the second long press it reverts the filtering according to the filter popup, not according to the quick filter bar.

Before/After Screenshots/Screen Record

  • Before:
qemu-system-x86_64_nbGG2YtWqP.mp4
  • After:
qemu-system-x86_64_ozMPwnBTyf.mp4

Acknowledgement

@naveensingh
Copy link
Member

Code looks good, I'll test myself later.

@naveensingh naveensingh merged commit 24d8c37 into FossifyOrg:master Jan 28, 2025
3 of 5 checks passed
@Aga-C Aga-C deleted the fix-quick-filter-long-press branch January 28, 2025 19:47
@fossifybot-legacy
Copy link
Member

FYI: This is available in 1.3.0. FossifyBot out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants