-
-
Notifications
You must be signed in to change notification settings - Fork 134
refactor: rename "EventType" symbols to "Calendar" #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename "EventType" symbols to "Calendar" #942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs a comprehensive refactoring to rename "EventType" terminology to "Calendar" throughout the codebase. The changes align the internal naming conventions with the actual domain concept being represented (calendars rather than event types).
- Renamed data model class
EventTypetoCalendarEntity - Renamed database DAO from
EventTypesDaotoCalendarsDao - Updated all UI components, dialogs, adapters, and activities to use "Calendar" naming
- Replaced field names like
eventTypewithcalendarIdin the Event model
Reviewed changes
Copilot reviewed 57 out of 58 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/menu/menu_event_types.xml | Updated menu item ID from add_event_type to add_calendar |
| app/src/main/res/layout/*.xml | Renamed all layout resource IDs from event_type to calendar patterns |
| app/src/main/kotlin/org/fossify/calendar/models/EventType.kt | Renamed class to CalendarEntity and method isSyncedEventType() to isSyncedCalendar() |
| app/src/main/kotlin/org/fossify/calendar/models/Event.kt | Renamed field eventType to calendarId |
| app/src/main/kotlin/org/fossify/calendar/interfaces/ | Renamed EventTypesDao to CalendarsDao and DeleteEventTypesListener to DeleteCalendarsListener |
| app/src/main/kotlin/org/fossify/calendar/helpers/*.kt | Updated all helper classes to use calendar terminology instead of event type |
| app/src/main/kotlin/org/fossify/calendar/dialogs/*.kt | Renamed dialogs from SelectEventTypeDialog to SelectCalendarDialog, etc. |
| app/src/main/kotlin/org/fossify/calendar/adapters/*.kt | Renamed adapters from FilterEventTypeAdapter to FilterCalendarAdapter, etc. |
| app/src/main/kotlin/org/fossify/calendar/activities/*.kt | Renamed ManageEventTypesActivity to ManageCalendarsActivity and EventTypePickerActivity to CalendarPickerActivity |
| app/src/main/kotlin/org/fossify/calendar/databases/EventsDatabase.kt | Updated database entity references from EventType::class to CalendarEntity::class |
| app/src/main/AndroidManifest.xml | Updated activity class names to reflect calendar naming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 59 out of 60 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Zero behavioral change.