Skip to content

refactor(settings): remove color customization lock and add thank you button #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Aug 24, 2025
Merged

refactor(settings): remove color customization lock and add thank you button #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions app/src/main/kotlin/org/fossify/camera/activities/SettingsActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ class SettingsActivity : SimpleActivity() {
super.onResume()
setupToolbar(binding.settingsToolbar, NavigationIcon.Arrow)

setupPurchaseThankYou()
setupCustomizeColors()
setupUseEnglish()
setupLanguage()
Expand Down Expand Up @@ -86,17 +85,9 @@ class SettingsActivity : SimpleActivity() {
}
}

private fun setupPurchaseThankYou() {
binding.settingsPurchaseThankYouHolder.beGoneIf(isOrWasThankYouInstalled())
binding.settingsPurchaseThankYouHolder.setOnClickListener {
launchPurchaseThankYouIntent()
}
}

private fun setupCustomizeColors() {
binding.settingsCustomizeColorsLabel.text = getCustomizeColorsString()
binding.settingsColorCustomizationHolder.setOnClickListener {
handleCustomizeColorsClick()
startCustomizationActivity()
}
}

Expand Down
14 changes: 2 additions & 12 deletions app/src/main/res/layout/activity_settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,20 +70,10 @@
android:layout_height="wrap_content"
android:orientation="vertical">

<RelativeLayout
<org.fossify.commons.views.PurchaseThankYouItem
android:id="@+id/settings_purchase_thank_you_holder"
style="@style/SettingsHolderTextViewOneLinerStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content">

<org.fossify.commons.views.MyTextView
android:id="@+id/settings_purchase_thank_you"
style="@style/SettingsTextLabelStyle"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/purchase_simple_thank_you" />

</RelativeLayout>
android:layout_height="wrap_content"/>

<RelativeLayout
android:id="@+id/settings_use_english_holder"
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ androidx-window = "1.4.0"
androidx-camera = "1.4.2"
androidx-ktx = "2.8.6"
#Fossify
commons = "4.4.2"
commons = "5.0.0"
#Gradle
gradlePlugins-agp = "8.11.1"
#build
Expand Down
Loading