Closes #20. Support high resolution output sizes. #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensingh
requested changes
Aug 30, 2025
app/src/main/kotlin/org/fossify/camera/implementations/CameraXPreview.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/camera/implementations/CameraXPreview.kt
Outdated
Show resolved
Hide resolved
leper
force-pushed
the
high_resolution_support
branch
from
5a9b75a to
fea7ed7
Compare
If the config preference is set to maximize quality, then also consider high resolution outputs. Switch to using a ResolutionSelector instead of the deprecated setTargetResolution API, as some of the higher resolution modes are only supported that way.
leper
force-pushed
the
high_resolution_support
branch
from
fea7ed7 to
cd07f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the config preference is set to maximize quality, then also consider high resolution outputs.
Switch to using a ResolutionSelector instead of the deprecated setTargetResolution API, as some of the higher resolution modes are only supported that way.
Type of change(s)
What changed and why
Fixes #20. After testing a variant of the diff in that ticket I noticed that it only fixes high resolution on one device I have access to, and another did not. The fix for that one was to switch to the newer API.
Before & after preview
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).