Skip to content

fix: override abstract methods in location listener #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 3 commits into from
Oct 5, 2025
Merged

fix: override abstract methods in location listener #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bba2c23
fix: override abstract methods in location listener
naveensingh Oct 5, 2025
0cb8c44
fix: suppress empty function block
naveensingh Oct 5, 2025
87b6466
docs: update changelog
naveensingh Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Fixed app crash when location service is disabled on Android 10 and prior ([#177])

## [1.3.0] - 2025-09-17
### Changed
Expand Down
20 changes: 16 additions & 4 deletions app/src/main/kotlin/org/fossify/camera/helpers/SimpleLocationManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.Manifest
import android.location.Location
import android.location.LocationListener
import android.location.LocationManager
import android.os.Bundle
import androidx.annotation.RequiresPermission
import org.fossify.camera.extensions.checkLocationPermission
import org.fossify.commons.activities.BaseSimpleActivity
Expand All @@ -15,12 +16,23 @@ class SimpleLocationManager(private val activity: BaseSimpleActivity) {
private const val LOCATION_UPDATE_MIN_DISTANCE_M = 10F
}

private var location: Location? = null

private val locationManager = activity.getSystemService(LocationManager::class.java)!!
private val locationListener = LocationListener { location ->
[email protected] = location
}

private var location: Location? = null
@Suppress("EmptyFunctionBlock")
private val locationListener = object: LocationListener {
override fun onLocationChanged(location: Location) {
[email protected] = location
}

// No-op methods that must be overridden.
// See https://github.com/FossifyOrg/Camera/issues/177
@Suppress("DEPRECATION")
override fun onStatusChanged(provider: String?, status: Int, extras: Bundle?) {}
override fun onProviderEnabled(provider: String) {}
override fun onProviderDisabled(provider: String) {}
}

fun getLocation(): Location? {
if (location == null) {
Expand Down
Loading