Skip to content

Conversation

@Joshix-1
Copy link
Contributor

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Improved code

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

Relies on the following changes

Acknowledgement

@Joshix-1
Copy link
Contributor Author

Joshix-1 commented Jan 28, 2025

Based this on #99, because I'm lazy

class AlarmReceiver : BroadcastReceiver() {

override fun onReceive(context: Context, intent: Intent) {
context.rescheduleEnabledAlarms();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the important line. The rest is improvements. There's a lot of weird shit in this code base.

@Aga-C
Copy link
Member

Aga-C commented Jan 28, 2025

I've tested it on the emulator and on the real phone, and the bug is still present.

@Joshix-1 Joshix-1 marked this pull request as draft January 28, 2025 21:22
@Joshix-1
Copy link
Contributor Author

Weird, I couldn't reproduce it in an emulator. I've tested with a snooze time of 1 Minute to reduce waiting time. But on my device it's broken as well. :(

I'll look into it.

@Joshix-1
Copy link
Contributor Author

I've tried to debug the problem and I couldn't reproduce the problem again 🤔
So this change seems to improve something.

@naveensingh
Copy link
Member

Hey, I'd like to have this fixed before the release so let me know if you are busy and I'll assign the issue to myself.

@Joshix-1
Copy link
Contributor Author

I currently do not have time to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No following alarm will ring until the first one is dismissed by hand

3 participants