Skip to content

Conversation

@KidScripty
Copy link

@KidScripty KidScripty commented Jan 4, 2026

Fix for spacing issue when lap time is longer than minutes when system font size is large e.g. 00:00.00

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Fixed stopwatch lap time display overlap/spacing issue
  • Adjusted layout constraints to prevent lap time entries from overlapping with each other
  • Improved visual spacing for better readability of lap times

Tests performed

  • Tested on physical device (Samsung SM-S926B) via wireless ADB
  • Verified lap time display with multiple lap entries
  • Confirmed no overlap or spacing issues

Before & after preview

Before: Lap times overlapped and were difficult to read
ignoreImageMinify
After: Lap times display with proper spacing and no overlap
ignoreImageMinify

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

…en lap time is longer than minutes e.g. 00:00.00 (#1)

Co-authored-by: AshBash <[email protected]>
Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the width isn't the correct fix.

@naveensingh naveensingh closed this Jan 5, 2026
@KidScripty
Copy link
Author

KidScripty commented Jan 5, 2026

@naveensingh What is the correct fix then in your opinion? Outline what you think the correct logic is to accomodate the additional width of the larger text and I will implement it.

A lot of your comments are completely unjustified frankly and completely outside the spirit of open source. You are now closing things from contributions for the sake of it without justification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stopwatch: lap times unseparated and/or truncated if font size is increased

2 participants