Skip to content

Conversation

@Aga-C
Copy link
Member

@Aga-C Aga-C commented Apr 3, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added a dialog for choosing first day of the week to any day.
  • By default, first day of the week is:
    • If a user in the old version of the app had set an option that Sunday should be first, Sunday will be set as a first day. Code for that is in MainActivity and can be removed in the next version after releasing this one.
    • If there wasn't anything set earlier, it will use the default first day of the week for current locale (same as in Calendar).
  • Modified the sorting by day logic to consider different first days of the week. Also, simplified that logic a bit.
  • Modified the alarm edit dialog to sort days properly.

Before/After Screenshots/Screen Record

qemu-system-x86_64_I2iSfeKKHL.mp4

Fixes the following issue(s)

Acknowledgement

@naveensingh naveensingh self-assigned this Feb 6, 2025
@naveensingh
Copy link
Member

It would be better to move the duplicated stuff to commons but updating commons requires more work so I guess I'll do that later, thanks!

@naveensingh naveensingh merged commit 11ab68b into FossifyOrg:master Feb 7, 2025
2 of 4 checks passed
@Aga-C Aga-C deleted the choose-first-day branch February 7, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting first day of week to any day

2 participants