Open data/obb folder in system app on Android 14+

[papjul]

What is it?

• Bugfix
• Feature
• Codebase improvement

Description of the changes in your PR

• Follow-up of More friendly access to data/obb folder on Android 14+ - Version 2 commons#90
• When browsing folders, offer the option to open in system app. Having this shortcut avoids having to keep two File Manager apps on your homescreen, one for when you need to access data/obb, and the other Fossify File Manager for the other cases, since Fossify File Manager can now send you directly on it whenever you need it with this PR.

Before/After Screenshots/Screen Record

• Before:

• After:
  On Android 14+

Fixes the following issue(s)

• Side step of Allow accessing /Android/data and /Android/obb with root #16

Relies on the following changes

• More friendly access to data/obb folder on Android 14+ - Version 2 commons#90 is a pre-requisite

Acknowledgement

• I read the contribution guidelines.

[naveensingh]

Just one issue, the progress bar never goes away. It should be selectively hidden for this case.

Tap data/obb ➜ Progress bar appears ➜ Open in system app ➜ Do (evil) things to other apps' data ➜ Press back ➜ The progress bar is still there hoping the files will load anytime now.

[papjul]

Just one issue, the progress bar never goes away. It should be selectively hidden for this case.

Tap data/obb ➜ Progress bar appears ➜ Open in system app ➜ Do (evil) things to other apps' data ➜ Press back ➜ The progress bar is still there hoping the files will load anytime now.

I noticed that, but it's unrelated to this issue. It's already there in the current releases.
I found out that returning false here fixes the issue, but then that means, that the function always returns false, and I have no idea about the consequences of this. The same true return value is also present in other similar functions, probably leading to the same issue, so it's far from being specific to this dialog.

[naveensingh]

I noticed that, but it's unrelated to this issue. It's already there in the current releases.

Yes, but there's a minor difference. In the latest release, the behavior is not polished but successfully granting the SAF permission does hide progress bar. With current changes, keeping the progress bar is not correct because we know that there's no more file loading going on and the user will be navigating away.

I found out that returning false here fixes the issue, but then that means, that the function always returns false, and I have no idea about the consequences of this.

I think it will be safer to call activity?.runOnUiThread { hideProgressBar() } after L188:

File-Manager/app/src/main/kotlin/org/fossify/filemanager/fragments/ItemsFragment.kt

Lines 183 to 189 in 55cc3bb

	@SuppressLint("NewApi")
	private fun getItems(path: String, callback: (originalPath: String, items: ArrayList<ListItem>) -> Unit) {
	ensureBackgroundThread {
	if (activity?.isDestroyed == false && activity?.isFinishing == false) {
	val config = context!!.config
	if (context.isRestrictedSAFOnlyRoot(path)) {
	activity?.handleAndroidSAFDialog(path) {

[papjul]

I think it will be safer to call activity?.runOnUiThread { hideProgressBar() } after L188

Done

[naveensingh]

org.fossify:commons:8439b1b80b is up now.

[papjul]

org.fossify:commons:8439b1b80b is up now.

Updated for this app

[naveensingh]

And it works™ :)

Thank you!