Skip to content

Conversation

@terofeev
Copy link
Contributor

@terofeev terofeev commented Feb 7, 2025

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Fix saving an unnecessary copy when cropping and resizing a picture.
  • Reuse the library's built-in progress bar to indicate the cropping process.

Before/After Screenshots/Screen Record

  • Before:
Before.mp4
  • After:
After.mp4

Fixes the following issue(s)

Acknowledgement

@naveensingh naveensingh self-assigned this Feb 7, 2025
@naveensingh
Copy link
Member

naveensingh commented Feb 7, 2025

Thanks for the PR!

@terofeev
Copy link
Contributor Author

terofeev commented Feb 8, 2025

Thanks for your comment!
I've fixed the share option.

I reviewed the "recommended" solution by the developer, but it comes with a few drawbacks:

  • We still create at least one temporary image.
  • The share option always generates its own copy via getTempImagePath, storing it in the app’s cache/images directory.
  • This approach unnecessarily consumes device resources like CPU, storage, etc.

So, in a new commit, I've completely switched to using our own cropping method without saving temporary images.

@naveensingh
Copy link
Member

Okay, thanks!

I'll do some final testing and merge soon.

@terofeev
Copy link
Contributor Author

terofeev commented Mar 5, 2025

Okay, thanks!

I'll do some final testing and merge soon.

Hi @naveensingh, just a friendly reminder in case you haven't had a chance to test yet. Thanks! 😊

@naveensingh naveensingh merged commit fbdfd05 into FossifyOrg:master Mar 5, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After edit picture, a copy is saved in app data

2 participants