feat: add option to overwrite original file in editor

[naveensingh]

Type of change(s)

• Bug fix
• Feature / enhancement
• Infrastructure / tooling (CI, build, deps, tests)
• Documentation

What changed and why

• Added Overwrite original option. It is always located inside the overflow menu to avoid confusion with the existing Save as action button and to prevent accidental overwrites.
• Refactored the code to remove duplication and improve readability.
• Moved Edit with action button into the overflow menu.

This makes #117 more obvious.

Tests performed

• Overwriting when editing images in-app
• Overwriting images opened from third-party apps
• Saving as a new file and overwriting manually by supplying the same file name as the original file
• Third-party crop intents
• Sharing edited image

Before & after preview

Closes the following issue(s)

• Closes Add an option to replace original after edit #62

Checklist

• I read the contribution guidelines.
• I manually tested my changes on device/emulator (if applicable).
• I updated the "Unreleased" section in CHANGELOG.md (if applicable).
• I have self-reviewed my pull request (no typos, formatting errors, etc.).
• All checks are passing.

[GfEW]

Great news overwrite is coming! Thanks for addressing.

Will there be a way to choose overwrite as default, or is it still a one-time choice? How many taps are needed each time? Ideally, should be two, including the confirmation.

[naveensingh]

Two taps. There will be no confirmation unless it is requested later.

[GfEW]

Two taps. There will be no confirmation unless it is requested later.

Nice, two taps.
In effect, it does "1. save, 2. confirm" already, serving to prevent accidental single tap overwrites.

This retroactively also fixes #227 .

[naveensingh]

The two steps include opening the overflow menu. If you ignore that, it's a one-tap process, really.

This retroactively also fixes #227 .

Not exactly. The original request is similar, but not the same as #62.

Changes to an image could simply be saved with a filename suffix, preserving the original.

[GfEW]

The two steps include opening the overflow menu. If you ignore that, it's a one-tap process, really.

Getting into overflow obviously takes a tap, but as the target is static, that first tap doesn't consume too much attention. Let's see how it feels like in practice.

This retroactively also fixes #227 .

Not exactly. The original request is similar, but not the same as #62.

The main argument there was whether or not to allow low-friction saving without a dialog (note e. g. could vs. should in the OP).
#62 goes beyond that.

But this is technicalities - glad to see the progress here, after all.

Thank you!