Skip to content

Conversation

@Korb
Copy link

@Korb Korb commented Nov 11, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

Russian text is currently region-independent. ru_RU ≡ ru_BY ≡ ru_KZ, etc.
The ru folder covers all Russian-language Android locales via fallback.
ru-RU only works for ru_RU; others see en-US.
Official F-Droid example — https://f-droid.org/docs/All_About_Descriptions_Graphics_and_Screenshots/#fastlane-structure

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@Korb Korb requested a review from naveensingh as a code owner November 11, 2025 10:20
Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Three things:

  • The filenames should use underscores, not hyphens. It should be full_description.txt and short_description.txt.
  • The original ru-RU folder should be deleted now.
  • I have scripts to do things org-wide, so I can do this for all other repos (unless you want to).

@Korb
Copy link
Author

Korb commented Nov 11, 2025

  • The filenames should use underscores, not hyphens. It should be full_description.txt and short_description.txt.

Yes, of course, I can't figure out when this error crept in. Please forgive my inattention.

  • The original ru-RU folder should be deleted now.

As you wish. Don't forget to fix the translation system links for new and old strings.

  • I have scripts to do things org-wide, so I can do this for all other repos (unless you want to).

No problem.

@Korb Korb requested a review from naveensingh November 11, 2025 10:46
@naveensingh
Copy link
Member

So, shall I close this, or will you be fixing the filename?

(Maybe you are using a translator?)

@Korb
Copy link
Author

Korb commented Nov 11, 2025

I was wrong.

The F-Droid client displays the description from the ru-RU folder for all Russian-language locales (ru_*), including, for example, ru-BY, if the ru folder is missing. This is due to the specific way metadata is processed in fdroidserver and the client: the server stores localized data under the ru-RU key in index-v2.json, and the client uses it as the base for the ru language, ignoring regional differences or applying Android's extended fallback (since Android 7+), where an available regional variant (ru-RU) is considered suitable for other regions of the same language in the absence of an exact match or the base ru.

Thus, ru-RU is a universal variant, suitable for both Google Play and F-Droid, which correctly applies it to all Russian-language locales in the absence of ru.

And vice versa, at the moment this is even a harmful change, because you still need to have the ru-RU by Google Play requirement, which will entail the presence of two files with identical content without any benefit. There will always be a risk that the translation will be included in one of them and not included, or included with a different wording, in the other.

PS. I'm more of a linguist than a programmer, and this is the first time I've encountered the "requested changes" and "requested/pending a review" features on GitHub, and I don't know what exactly to do with them here.

@Korb Korb closed this Nov 11, 2025
@naveensingh
Copy link
Member

Thanks for looking into it! I guess I need to be even more critical of new changes 😅

I'm more of a linguist than a programmer, and this is the first time I've encountered the "requested changes" and "requested/pending a review" features on GitHub, and I don't know what exactly to do with them here.

Good to know. I'm very curious about learning new languages.

Requested changes: Your pull request has been reviewed, and the reviewer wants you to make some changes.
Pending review: Self-explanatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants