fix: use proper layout params when hiding primary actions #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash that occurred when the editor was launched from other apps for cropping purposes. The crash was caused by attempting to cast layout parameters to the wrong type (RelativeLayout instead of ConstraintLayout).
Key Changes
- Corrected layout parameter type from
RelativeLayout.LayoutParamstoConstraintLayout.LayoutParamsto match the actual parent layout - Moved
isCropIntentinitialization earlier to support conditional edge-to-edge padding setup - Added null-safe casting and proper constraint setting for the crop/rotate actions when in crop intent mode
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/kotlin/org/fossify/gallery/activities/EditActivity.kt | Fixed crash by using correct ConstraintLayout.LayoutParams instead of RelativeLayout.LayoutParams when adjusting bottom action constraints in crop mode |
| CHANGELOG.md | Added changelog entry for the crash fix with reference to issue #786 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My new keyboard is still in transit :(
Closes #786