Skip to content

fix: show stroke around on color picker button #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Dec 16, 2025
Merged

fix: show stroke around on color picker button #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Fixed invisible color picker button in black themes ([#337])

## [1.10.0] - 2025-12-16
### Added
Expand Down Expand Up @@ -231,6 +233,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#241]: https://github.com/FossifyOrg/Gallery/issues/241
[#275]: https://github.com/FossifyOrg/Gallery/issues/275
[#325]: https://github.com/FossifyOrg/Gallery/issues/325
[#337]: https://github.com/FossifyOrg/Gallery/issues/337
[#362]: https://github.com/FossifyOrg/Gallery/issues/362
[#365]: https://github.com/FossifyOrg/Gallery/issues/365
[#375]: https://github.com/FossifyOrg/Gallery/issues/375
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/kotlin/org/fossify/gallery/activities/EditActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import com.zomato.photofilters.FilterPack
import com.zomato.photofilters.imageprocessors.Filter
import org.fossify.commons.dialogs.ColorPickerDialog
import org.fossify.commons.extensions.applyColorFilter
import org.fossify.commons.extensions.setFillWithStroke
import org.fossify.commons.extensions.beGone
import org.fossify.commons.extensions.beGoneIf
import org.fossify.commons.extensions.beVisible
Expand Down Expand Up @@ -813,7 +814,8 @@ class EditActivity : BaseCropActivity() {

private fun updateDrawColor(color: Int) {
drawColor = color
binding.bottomEditorDrawActions.bottomDrawColor.applyColorFilter(color)
binding.bottomEditorDrawActions.bottomDrawColor
.setFillWithStroke(color, getProperBackgroundColor())
config.lastEditorDrawColor = color
binding.editorDrawCanvas.updateColor(color)
}
Expand Down
5 changes: 3 additions & 2 deletions app/src/main/res/layout/bottom_editor_draw_actions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/bottom_editor_draw_actions_wrapper"
android:layout_width="match_parent"
android:layout_height="@dimen/bottom_actions_height"
Expand Down Expand Up @@ -38,10 +39,10 @@
android:clickable="false"
android:contentDescription="@null"
android:padding="@dimen/small_margin"
android:src="@drawable/circle_background"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintRight_toLeftOf="@+id/bottom_draw_undo"
app:layout_constraintTop_toTopOf="parent" />
app:layout_constraintTop_toTopOf="parent"
tools:src="@drawable/circle_background" />

<ImageView
android:id="@+id/bottom_draw_undo"
Expand Down
Loading