Skip to content

fix: avoid division by zero #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Jun 10, 2025
Merged

fix: avoid division by zero #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions indicator-fast-scroll/src/main/java/com/reddit/indicatorfastscroll/FastScrollerView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,14 +353,22 @@ class FastScrollerView @JvmOverloads constructor(
}
is TextView -> {
@Suppress("UNCHECKED_CAST")
val possibleTouchedIndicators = view.tag as List<FastScrollItemIndicator.Text>
val possibleTouchedIndicators = view.tag as List<FastScrollItemIndicator.Text>
if (possibleTouchedIndicators.isEmpty() || heightForCalculations == 0) {
return false
}

val textIndicatorsTouchY = touchY - view.top

val textLineHeight = heightForCalculations / possibleTouchedIndicators.size
val touchedIndicatorIndex = min(
textIndicatorsTouchY / textLineHeight,
possibleTouchedIndicators.lastIndex
)
val touchedIndicatorIndex = if (textLineHeight > 0) {
min(
textIndicatorsTouchY / textLineHeight,
possibleTouchedIndicators.lastIndex
)
} else {
0
}

val touchedIndicator = possibleTouchedIndicators[touchedIndicatorIndex]
val centerY = view.y.toInt() + (textLineHeight / 2) + (touchedIndicatorIndex * textLineHeight)
Expand Down
Loading