Skip to content

fix: ensure proper insets are applied on startup #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Oct 29, 2025
Merged

fix: ensure proper insets are applied on startup #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- Fixed invisible numbers in the top row ([#100])
- Fixed overlap between keyboard and navigation bar ([#117])

## [1.5.0] - 2025-09-23
### Added
Expand Down Expand Up @@ -102,6 +103,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#47]: https://github.com/FossifyOrg/Keyboard/issues/47
[#78]: https://github.com/FossifyOrg/Keyboard/issues/78
[#100]: https://github.com/FossifyOrg/Keyboard/issues/100
[#117]: https://github.com/FossifyOrg/Keyboard/issues/117
[#133]: https://github.com/FossifyOrg/Keyboard/issues/133
[#134]: https://github.com/FossifyOrg/Keyboard/issues/134
[#136]: https://github.com/FossifyOrg/Keyboard/issues/136
Expand Down
9 changes: 6 additions & 3 deletions app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import androidx.autofill.inline.v1.InlineSuggestionUi
import androidx.core.graphics.drawable.toBitmap
import androidx.core.view.ViewCompat
import androidx.core.view.WindowCompat
import androidx.core.view.WindowInsetsCompat
import androidx.core.view.WindowInsetsCompat.Type
import androidx.core.view.updatePadding
import org.fossify.commons.extensions.*
import org.fossify.commons.helpers.*
Expand Down Expand Up @@ -96,6 +96,9 @@ class SimpleKeyboardIME : InputMethodService(), OnKeyboardActionListener, Shared
override fun onStartInputView(editorInfo: EditorInfo?, restarting: Boolean) {
super.onStartInputView(editorInfo, restarting)
updateBackgroundColors()
binding.keyboardHolder.post {
ViewCompat.requestApplyInsets(binding.keyboardHolder)
}
}

override fun onPress(primaryCode: Int) {
Expand Down Expand Up @@ -557,8 +560,8 @@ class SimpleKeyboardIME : InputMethodService(), OnKeyboardActionListener, Shared
window.window?.apply {
WindowCompat.enableEdgeToEdge(this)
ViewCompat.setOnApplyWindowInsetsListener(binding.keyboardHolder) { view, insets ->
val bottomPadding = insets.getInsets(WindowInsetsCompat.Type.systemBars()).bottom
binding.keyboardHolder.updatePadding(bottom = bottomPadding)
val system = insets.getInsetsIgnoringVisibility(Type.navigationBars())
binding.keyboardHolder.updatePadding(bottom = system.bottom)
insets
}
}
Expand Down
Loading