-
-
Notifications
You must be signed in to change notification settings - Fork 57
[#234] Added option to show (default) or not the emoji key in the settings menu. #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in the settings menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work fine!
Instead of calling .adjustForEmojiButton() everywhere, it'll be cleaner to create a helper for constructing the keyboard:
private fun constructKeyboard(xmlLayoutResId: Int, enterKeyType: Int): MyKeyboard {
return MyKeyboard(
context = this,
xmlLayoutResId = xmlLayoutResId,
enterKeyType = enterKeyType
).adjustForEmojiButton()
}And then replace every MyKeyboard(*args).adjustForEmojiButton() occurrence with this function. More comments below:
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
…in the settings menu. Fix: Address reviewer feedback
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
…in the settings menu. Fix: Address reviewer feedback
naveensingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a nice day!
Type of change(s)
What changed and why
Tests performed
Before & after preview
The key simply appear / disappear I don't think an image is needed.
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).