Skip to content

Conversation

@m-gianfagna
Copy link
Contributor

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Added an option to show (default) or not the emoji key in the bottom, next to the spacebar. The option is down the "Start sentences with a capital letter" option in the settings menu.

Tests performed

  • Tested on Samsung A53 5G

Before & after preview

The key simply appear / disappear I don't think an image is needed.

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work fine!

Instead of calling .adjustForEmojiButton() everywhere, it'll be cleaner to create a helper for constructing the keyboard:

    private fun constructKeyboard(xmlLayoutResId: Int, enterKeyType: Int): MyKeyboard {
        return MyKeyboard(
            context = this,
            xmlLayoutResId = xmlLayoutResId,
            enterKeyType = enterKeyType
        ).adjustForEmojiButton()
    }

And then replace every MyKeyboard(*args).adjustForEmojiButton() occurrence with this function. More comments below:

…in the settings menu.

Fix: Address reviewer feedback
Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a nice day!

@naveensingh naveensingh merged commit a755abd into FossifyOrg:main Nov 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: Option to disable the emoji key

2 participants