Skip to content

Conversation

@rishabhhgupta
Copy link

@rishabhhgupta rishabhhgupta commented Nov 17, 2025

Type of change(s)

  • Feature / enhancement
    1. Added multiple skin of each emoij like 👍: 👍🏻👍🏼👍🏽👍🏾👍🏿, By holding on each emoji
    2. Ability to search emoji using the search term that fit for the emoji.
    3. Each emoji search terms is fit with the modern Genz search terms and also prefine define common search terms like red flag 🚩, happy: 😊☺😆😄😁😂
      4. Also compatible with different keyboard themes.

What changed and why

For why it make the emoji get faster rather than scrolling to the end and manually find the 🥕 emoji or any other emoji rather than just search "carrot"

Remove earlier emoji loading mechanism(recyclerview and adapter) and replace with androidx.emojipicker and also make changes into it
the extra changes in the androidx.emojipicker are

  1. To become searchable by adding each emoji search terms i.e in the files Emojipicker/src/main/res/raw/*.csv by default emoji picker have the csv file but it have only emoji variable i added variation+search terms

  2. Change emojoPIcker colors and background according the keyboard theme by
    emojiPickerView.build(mTextColor){}

here mTextColor is the theme color

  1. Added function to only show recent used emoji by
    emojiPIckerVIew.buildEmojiPickerItems(onlyRecentEmojies=true)

  2. Show only users search term matching emojies by
    emojiPIckerVIew.buildEmojiPickerItems(onlyRecentEmojies=false, description='User search terms')

  3. Added class OtherInputConnection.kt to shift the typing focus to the keyboard SearchView for emoji search

Tests performed

I tested on the Android 15 and Android 14 on both Emulator and physical android device and both work fine and no issue I got

Before & after preview

Here is the after preview video after adding above features click here

Checklist

  • I read the contribution guidelines.: done
  • I manually tested my changes on device/emulator (if applicable). : done
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.). : yeah
  • All checks are passing.

1. update the color accoding to the keyboard theme
2. added search term keyword on each emoji helpful during user
3. change the emojipicker to show only recent or only search terms result

Added OtherInputConnection.kt use to change the input focus to the keyboard for that it work only on "androidx.appcompat.widget.AppCompatAutoCompleteTextView"

other minor changes like shifstatechange accoding to the  keyboard shift to the OtherInputConnection.kt
@rishabhhgupta
Copy link
Author

hey in the video you see the toast error it's from the Youtube music I listen song during screen recording, so it's not from the keyboard

@naveensingh
Copy link
Member

naveensingh commented Nov 17, 2025

Thanks, but dropping the entire androidx module in this repo isn't the right approach, and this PR is too big to review.

Also, please avoid working on issues that are assigned to someone else.

@rishabhhgupta
Copy link
Author

rishabhhgupta commented Nov 17, 2025

i didn't understand is it assigned someone else? I just like to add the features becuase i love the keyboard and I just add only androidx.emojipicker module only and also adding for the reason to fork that module to adding search terms and variations, background and colors changes according to the keyboard theme and ability to do the searching to filter out the emojies, Can i not fix the workflow issues and send another pr?
ignoreImageMinify

Or should i use the emoij picker class into the keyboard and merge it rather than having a separate module

@naveensingh
Copy link
Member

i didn't understand is it assigned someone else?

Yep, see #23

adding search terms and variations, background and colors changes according to the keyboard theme and ability to do the searching

I'm aware. Adding the whole module directly is still not a good idea. It'll be handled some other way.

@rishabhhgupta
Copy link
Author

rishabhhgupta commented Nov 17, 2025

my last question did i work on this area or not, next pull request would be not using androidx.emojipicker at all but rather using existing code and add the features that i already do in this pull request? btw it took me 4-5 week to build this and do you see the video that use the feature

@rishabhhgupta
Copy link
Author

if you look in the module it just get the list of emoji and parse them on the recyclerview with category title, listen user pressed to store in recent Items list and hold gesture to view varient, that' it, it just break the code into different classes. if you go through module it have only 24 classes straight no subfolder and csv files that's it. review it and androidx.emojipicker is a apache 2.0 licence and again it's only this classes and whole androidx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants