-
-
Notifications
You must be signed in to change notification settings - Fork 57
added Androidx.emojipicker and make changes like #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. update the color accoding to the keyboard theme 2. added search term keyword on each emoji helpful during user 3. change the emojipicker to show only recent or only search terms result Added OtherInputConnection.kt use to change the input focus to the keyboard for that it work only on "androidx.appcompat.widget.AppCompatAutoCompleteTextView" other minor changes like shifstatechange accoding to the keyboard shift to the OtherInputConnection.kt
|
hey in the video you see the toast error it's from the Youtube music I listen song during screen recording, so it's not from the keyboard |
|
Thanks, but dropping the entire androidx module in this repo isn't the right approach, and this PR is too big to review. Also, please avoid working on issues that are assigned to someone else. |
Yep, see #23
I'm aware. Adding the whole module directly is still not a good idea. It'll be handled some other way. |
|
my last question did i work on this area or not, next pull request would be not using androidx.emojipicker at all but rather using existing code and add the features that i already do in this pull request? btw it took me 4-5 week to build this and do you see the video that use the feature |
|
if you look in the module it just get the list of emoji and parse them on the recyclerview with category title, listen user pressed to store in recent Items list and hold gesture to view varient, that' it, it just break the code into different classes. if you go through module it have only 24 classes straight no subfolder and csv files that's it. review it and androidx.emojipicker is a apache 2.0 licence and again it's only this classes and whole androidx |

Type of change(s)
4. Also compatible with different keyboard themes.
What changed and why
For why it make the emoji get faster rather than scrolling to the end and manually find the 🥕 emoji or any other emoji rather than just search "carrot"
Remove earlier emoji loading mechanism(recyclerview and adapter) and replace with androidx.emojipicker and also make changes into it
the extra changes in the androidx.emojipicker are
To become searchable by adding each emoji search terms i.e in the files Emojipicker/src/main/res/raw/*.csv by default emoji picker have the csv file but it have only emoji variable i added variation+search terms
Change emojoPIcker colors and background according the keyboard theme by
emojiPickerView.build(mTextColor){}here mTextColor is the theme color
Added function to only show recent used emoji by
emojiPIckerVIew.buildEmojiPickerItems(onlyRecentEmojies=true)Show only users search term matching emojies by
emojiPIckerVIew.buildEmojiPickerItems(onlyRecentEmojies=false, description='User search terms')Added class OtherInputConnection.kt to shift the typing focus to the keyboard SearchView for emoji search
Tests performed
I tested on the Android 15 and Android 14 on both Emulator and physical android device and both work fine and no issue I got
Before & after preview
Here is the after preview video after adding above features click here
Checklist
CHANGELOG.md(if applicable).