Skip to content

fix: properly handle keyword blocking #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 3 commits into from
Oct 5, 2025
Merged

fix: properly handle keyword blocking #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fffc585
fix: properly handle keyword blocking
naveensingh Oct 1, 2025
b5237c3
build: switch mmslib to official version
naveensingh Oct 5, 2025
66eb2b1
docs: update changelog
naveensingh Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Reordered menu options throughout the app

### Fixed
- Fixed keyword blocking for MMS messages ([#99])
- Fixed contact number selection when adding members to a group ([#456])
- Fixed a glitch in pattern lock after incorrect attempts

Expand Down Expand Up @@ -138,6 +139,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#13]: https://github.com/FossifyOrg/Messages/issues/13
[#70]: https://github.com/FossifyOrg/Messages/issues/70
[#75]: https://github.com/FossifyOrg/Messages/issues/75
[#99]: https://github.com/FossifyOrg/Messages/issues/99
[#115]: https://github.com/FossifyOrg/Messages/issues/115
[#135]: https://github.com/FossifyOrg/Messages/issues/135
[#153]: https://github.com/FossifyOrg/Messages/issues/153
Expand Down
2 changes: 1 addition & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ dependencies {
implementation(libs.fossify.commons)
implementation(libs.eventbus)
implementation(libs.indicator.fast.scroll)
implementation(libs.android.smsmms)
implementation(libs.mmslib)
implementation(libs.androidx.swiperefreshlayout)
implementation(libs.androidx.constraintlayout)
implementation(libs.androidx.lifecycle.process)
Expand Down
9 changes: 4 additions & 5 deletions app/src/main/kotlin/org/fossify/messages/receivers/MmsReceiver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,17 @@ import org.fossify.messages.helpers.ReceiverUtils.isMessageFilteredOut
import org.fossify.messages.helpers.refreshMessages
import org.fossify.messages.models.Message

// more info at https://github.com/klinker41/android-smsmms
class MmsReceiver : MmsReceivedReceiver() {

override fun isAddressBlocked(context: Context, address: String): Boolean {
val normalizedAddress = address.normalizePhoneNumber()
return context.isNumberBlocked(normalizedAddress)
}

override fun isContentBlocked(context: Context, content: String): Boolean {
return isMessageFilteredOut(context, content)
}

override fun onMessageReceived(context: Context, messageUri: Uri) {
val mms = context.getLatestMMS() ?: return
val address = mms.getSender()?.phoneNumbers?.first()?.normalizedNumber ?: ""
Expand Down Expand Up @@ -62,10 +65,6 @@ class MmsReceiver : MmsReceivedReceiver() {
size: Int,
address: String
) {
if (isMessageFilteredOut(context, mms.body)) {
return
}

val glideBitmap = try {
Glide.with(context)
.asBitmap()
Expand Down
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ eventbus = "3.3.1"
room = "2.8.1"
#Fossify
commons = "5.2.0"
android-smsmms = "c3e678befd"
mmslib = "1.0.0"
indicator-fast-scroll = "4524cd0b61"
#Gradle
gradlePlugins-agp = "8.11.1"
Expand All @@ -43,7 +43,7 @@ compose-detekt = { module = "io.nlopez.compose.rules:detekt", version.ref = "det
#Fossify
fossify-commons = { module = "org.fossify:commons", version.ref = "commons" }
indicator-fast-scroll = { module = "org.fossify:IndicatorFastScroll", version.ref = "indicator-fast-scroll" }
android-smsmms = { module = "org.fossify:android-smsmms", version.ref = "android-smsmms" }
mmslib = { module = "org.fossify:mmslib", version.ref = "mmslib" }
#EventBus
eventbus = { module = "org.greenrobot:eventbus", version.ref = "eventbus" }
#Helpers
Expand Down
Loading