Skip to content

Conversation

@naveensingh
Copy link
Member

@naveensingh naveensingh commented Oct 28, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Applied proper selection when marking messages as read. This was not a big issue before because users rarely marked long threads as read/unread, but the fix in feat: add unread badge count for conversations #560 made Mark as read unconditional on resume, leading to SQLite pool exhaustion.
  • Mark as read should work better now due to this change.

Tests performed

  • Tested scrolling and sending messages in a thread containing 10,000 fake SMS and MMS messages inserted into the telephony database.

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@naveensingh naveensingh added testers needed We need testers for this issue or pull request and removed testers needed We need testers for this issue or pull request labels Oct 28, 2025
@naveensingh naveensingh merged commit 07b7e92 into main Oct 28, 2025
11 checks passed
@naveensingh naveensingh deleted the naveensingh/improve-mark-as-read-performance branch October 28, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashes and App not responding errors in version 1.5.0

2 participants