Skip to content

feat: allow copying multiple messages #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Nov 22, 2025
Merged

feat: allow copying multiple messages #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- Ability to select and copy multiple text messages at once ([#600])

## [1.6.0] - 2025-10-29
### Changed
Expand Down Expand Up @@ -200,6 +202,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#561]: https://github.com/FossifyOrg/Messages/issues/561
[#562]: https://github.com/FossifyOrg/Messages/issues/562
[#574]: https://github.com/FossifyOrg/Messages/issues/574
[#600]: https://github.com/FossifyOrg/Messages/issues/600

[Unreleased]: https://github.com/FossifyOrg/Messages/compare/1.6.0...HEAD
[1.6.0]: https://github.com/FossifyOrg/Messages/compare/1.5.0...1.6.0
Expand Down
16 changes: 11 additions & 5 deletions app/src/main/kotlin/org/fossify/messages/adapters/ThreadAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,14 +115,14 @@ class ThreadAdapter(

override fun prepareActionMode(menu: Menu) {
val isOneItemSelected = isOneItemSelected()
val selectedItem = getSelectedItems().firstOrNull() as? Message
val hasText = selectedItem?.body != null && selectedItem.body != ""
val selectedMessages = getSelectedItems().filterIsInstance<Message>()
val hasText = selectedMessages.any { it.body.isNotEmpty() }
val showSaveAs = getSelectedItems().all {
it is Message && (it.attachment?.attachments?.size ?: 0) > 0
} && getSelectedAttachments().isNotEmpty()

menu.apply {
findItem(R.id.cab_copy_to_clipboard).isVisible = isOneItemSelected && hasText
findItem(R.id.cab_copy_to_clipboard).isVisible = hasText
findItem(R.id.cab_save_as).isVisible = showSaveAs
findItem(R.id.cab_share).isVisible = isOneItemSelected && hasText
findItem(R.id.cab_forward_message).isVisible = isOneItemSelected
Expand Down Expand Up @@ -219,8 +219,14 @@ class ThreadAdapter(
}

private fun copyToClipboard() {
val firstItem = getSelectedItems().firstOrNull() as? Message ?: return
activity.copyToClipboard(firstItem.body)
val selectedMessages = getSelectedItems().filterIsInstance<Message>()
val textToCopy = selectedMessages
.mapNotNull { message -> message.body.takeIf { it.isNotEmpty() } }
.joinToString("\n\n")

if (textToCopy.isNotEmpty()) {
activity.copyToClipboard(textToCopy)
}
}

private fun getSelectedAttachments(): List<Attachment> {
Expand Down
Loading