Skip to content

fix: put player on the main thread to prevent internal calls on wrong thread #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
naveensingh merged 3 commits into from
Nov 8, 2025
Merged

fix: put player on the main thread to prevent internal calls on wrong thread #303

naveensingh merged 3 commits into from
Nov 8, 2025

Conversation

@naveensingh
Copy link
Member

@naveensingh naveensingh commented Nov 8, 2025 •
edited
Loading

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Removed the dedicated player thread.
  • Minor readability improvement in TrackActivity.

Tests performed

  • Tested playback with 10000 items

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@naveensingh
fix: put player on the main thread
7b51fe0 
Removed the dedicated player thread. All player operations are now delegated to the application's main looper, as recommended by the official ExoPlayer documentation.

Refs: #298, androidx/media#2884
@naveensingh
refactor: rely on the player implementation to handle custom seek beh…
a894090 
…avior
@naveensingh
docs: update changelog
3e7c530
@naveensingh naveensingh merged commit 9e87966 into main Nov 8, 2025
8 checks passed
@naveensingh naveensingh deleted the naveensingh/switch-to-main-thread branch November 8, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Playback stops and app crashes when cleared from recents

2 participants

@naveensingh