Closed
Conversation
First file of two to be edited sleepTimerChanged wasn't used so I added it in the showSleepTimer under the condition that it is called if the value of sleeptimer is above 0. Also in sleepTimerChanged I put the two binding under a if condition checking if the value of the sleeptimer it above 0,, otherwise if it is 0 it is left to finish but could be uneccessary because the function shouldn't be called if the timer is already at 0. Sorry for making the fix in two pull request I'm still new to this, next request if final and only affect the file: SleepTimer.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First file of two to be edited to fix this bug: #345
This request affect the file MainActivity.kt
sleepTimerChanged wasn't used so I added it in the showSleepTimer under the condition that it is called if the value of sleeptimer is above 0. Also in sleepTimerChanged I put the two binding under a if condition checking if the value of the sleeptimer it above 0,, otherwise if it is 0 it is left to finish but could be uneccessary because the function shouldn't be called if the timer is already at 0.
Sorry for making the fix in two pull request I'm still new to this, next request is final and will only affect the file: SleepTimer.kt
Type of change(s)
What changed and why
Tests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).