fix: always use proper sorting in favorites fragment #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New custom sorting in favorites tab is not kept until the app is restarted
naveensingh
requested changes
Oct 15, 2025
Member
naveensingh
left a comment
naveensingh
left a comment
There was a problem hiding this comment.
Please update the "Unreleased" section in the changelog as requested by the PR template. You can check other PRs to see how it's done. Example entry: Fixed custom favorites sorting not taking effect until restart.
Also, read the contribution guidelines if you haven't done so.
app/src/main/kotlin/org/fossify/phone/fragments/FavoritesFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/phone/fragments/FavoritesFragment.kt
Outdated
Show resolved
Hide resolved
naveensingh
added
the
waiting for author
Contributor
Author
ChangeLog Added |
naveensingh
requested changes
Oct 15, 2025
app/src/main/kotlin/org/fossify/phone/fragments/FavoritesFragment.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Naveen Singh <[email protected]>
naveensingh
reviewed
Oct 15, 2025
# Conflicts: # CHANGELOG.md
naveensingh
reviewed
Oct 15, 2025
7 tasks
naveensingh
changed the title
naveensingh
requested changes
Oct 16, 2025
app/src/main/kotlin/org/fossify/phone/fragments/FavoritesFragment.kt
Outdated
Show resolved
Hide resolved
naveensingh
approved these changes
Oct 16, 2025
Member
naveensingh
left a comment
naveensingh
left a comment
There was a problem hiding this comment.
I fixed it myself, thanks!
Notes for the future:
- Do not remove PR template.
- Link the issue you are working on as required in the template. It won't get automatically closed otherwise.
naveensingh
removed
the
waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New custom sorting in favorites tab is not kept until the app is restarted