Skip to content

fix: prevent double top bars in non-system themes #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 2 commits into from
Oct 29, 2025
Merged

fix: prevent double top bars in non-system themes #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc0966b
fix: prevent double top bars in non-system themes
naveensingh Oct 29, 2025
54ea57b
fix: prevent double top bars in non-system themes
naveensingh Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions commons/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
<item name="colorControlHighlight">@color/activated_item_foreground</item>
<item name="bottomSheetDialogTheme">@style/BottomSheetDialogTheme</item>
<item name="android:forceDarkAllowed">false</item>
<item name="windowActionModeOverlay">true</item>
<item name="actionOverflowMenuStyle">@style/TopPopupMenu.Overflow.Dark</item>
<item name="android:actionOverflowButtonStyle">@style/ActionMenuOverflowIcon</item>
<item name="android:windowLightStatusBar">false</item>
Expand Down Expand Up @@ -507,6 +508,7 @@
<item name="colorControlHighlight">@color/activated_item_foreground</item>
<item name="android:colorControlActivated">@color/dark_grey</item>
<item name="bottomSheetDialogTheme">@style/BottomSheetDialogTheme</item>
<item name="windowActionModeOverlay">true</item>
</style>

<style name="AppTheme.White.LightTextColor" parent="AppTheme.White">
Expand All @@ -526,6 +528,7 @@
<item name="android:colorControlActivated">@color/dark_grey</item>
<item name="bottomSheetDialogTheme">@style/BottomSheetDialogTheme</item>
<item name="android:actionOverflowButtonStyle">@style/ActionMenuOverflowIcon</item>
<item name="windowActionModeOverlay">true</item>
</style>

<style name="AppTheme.BlackAndWhite" parent="AppTheme.Base">
Expand All @@ -542,6 +545,7 @@
<item name="android:colorControlActivated">@color/md_grey_white</item>
<item name="bottomSheetDialogTheme">@style/BottomSheetDialogTheme</item>
<item name="android:actionOverflowButtonStyle">@style/ActionMenuOverflowIcon</item>
<item name="windowActionModeOverlay">true</item>
</style>

<style name="AppTheme.BlackAndWhite.DarkTextColor" parent="AppTheme.BlackAndWhite">
Expand All @@ -561,6 +565,7 @@
<item name="android:colorControlActivated">@color/md_grey_white</item>
<item name="bottomSheetDialogTheme">@style/BottomSheetDialogTheme</item>
<item name="android:actionOverflowButtonStyle">@style/ActionMenuOverflowIcon</item>
<item name="windowActionModeOverlay">true</item>
</style>

<!-- themes with using transparent top action and status bars -->
Expand Down
Loading