Skip to content

fix: dont pack contact item elements together #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Oct 29, 2025
Merged

fix: dont pack contact item elements together #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions commons/src/main/res/layout/item_contact_with_number.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/item_contact_frame"
android:layout_width="match_parent"
android:layout_height="@dimen/two_line_list_item_min_height"
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/tiny_margin"
android:background="@drawable/selector_clickable"
android:clickable="true"
android:focusable="true"
android:minHeight="@dimen/two_line_list_item_min_height"
android:paddingHorizontal="@dimen/list_item_padding_horizontal"
android:paddingVertical="@dimen/list_item_padding_vertical">

Expand Down Expand Up @@ -36,8 +37,6 @@
app:layout_constraintEnd_toStartOf="@+id/drag_handle_icon"
app:layout_constraintStart_toEndOf="@+id/item_contact_image"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintVertical_bias="0.5"
app:layout_constraintVertical_chainStyle="packed"
tools:text="John Doe" />

<TextView
Expand All @@ -52,7 +51,6 @@
app:layout_constraintEnd_toStartOf="@+id/drag_handle_icon"
app:layout_constraintStart_toEndOf="@+id/item_contact_image"
app:layout_constraintTop_toBottomOf="@+id/item_contact_name"
app:layout_constraintVertical_bias="0.5"
tools:text="0123 456 789" />

<ImageView
Expand Down
3 changes: 2 additions & 1 deletion commons/src/main/res/layout/item_contact_without_number.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/item_contact_frame"
android:layout_width="match_parent"
android:layout_height="@dimen/one_line_list_item_min_height"
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/tiny_margin"
android:background="@drawable/selector_clickable"
android:clickable="true"
android:focusable="true"
android:minHeight="@dimen/one_line_list_item_min_height"
android:paddingHorizontal="@dimen/list_item_padding_horizontal"
android:paddingVertical="@dimen/list_item_padding_vertical">

Expand Down
Loading