Skip to content

fix: avoid resetting padding/margin from previous calls #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Nov 30, 2025
Merged

fix: avoid resetting padding/margin from previous calls #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions commons/src/main/kotlin/org/fossify/commons/extensions/View.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ fun View.isInvisible() = visibility == View.INVISIBLE

fun View.isGone() = visibility == View.GONE

fun View.performHapticFeedback() = performHapticFeedback(HapticFeedbackConstants.VIRTUAL_KEY, HapticFeedbackConstants.FLAG_IGNORE_GLOBAL_SETTING)
fun View.performHapticFeedback() = performHapticFeedback(
HapticFeedbackConstants.VIRTUAL_KEY,
HapticFeedbackConstants.FLAG_IGNORE_GLOBAL_SETTING
)

fun View.fadeIn(duration: Long = SHORT_ANIMATION_DURATION) {
animate().alpha(1f).setDuration(duration).withStartAction { beVisible() }.start()
Expand Down Expand Up @@ -95,17 +98,17 @@ fun View.ensureBasePadding(): IntArray {
}

fun View.updatePaddingWithBase(
@Px left: Int = 0,
@Px top: Int = 0,
@Px right: Int = 0,
@Px bottom: Int = 0,
@Px left: Int? = null,
@Px top: Int? = null,
@Px right: Int? = null,
@Px bottom: Int? = null,
) {
val base = ensureBasePadding()
updatePadding(
left = base[0] + left,
top = base[1] + top,
right = base[2] + right,
bottom = base.last() + bottom
left = left?.let { base[0] + it } ?: paddingLeft,
top = top?.let { base[1] + it } ?: paddingTop,
right = right?.let { base[2] + it } ?: paddingRight,
bottom = bottom?.let { base[3] + it } ?: paddingBottom,
)
}

Expand All @@ -119,19 +122,19 @@ fun View.ensureBaseMargin(): IntArray {
}

fun View.updateMarginWithBase(
@Px left: Int = 0,
@Px top: Int = 0,
@Px right: Int = 0,
@Px bottom: Int = 0,
@Px left: Int? = null,
@Px top: Int? = null,
@Px right: Int? = null,
@Px bottom: Int? = null,
) {
val base = ensureBaseMargin()
try {
updateLayoutParams<ViewGroup.MarginLayoutParams> {
leftMargin = base[0] + left
topMargin = base[1] + top
rightMargin = base[2] + right
bottomMargin = base.last() + bottom
leftMargin = left?.let { base[0] + it } ?: leftMargin
topMargin = top?.let { base[1] + it } ?: topMargin
rightMargin = right?.let { base[2] + it } ?: rightMargin
bottomMargin = bottom?.let { base[3] + it } ?: bottomMargin
}
} catch (ignored: ClassCastException) {
} catch (_: ClassCastException) {
}
}
2 changes: 1 addition & 1 deletion detekt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ style:
active: true
ignoreAnnotated: ["Composable"]
ignoreEnums: true
ignoreNumbers: ["-1", "0", "1", "2", "42", "1000"]
ignoreNumbers: ["-1", "0", "1", "2", "3", "42", "1000"]
MaxLineLength:
active: true
maxLineLength: 120
Expand Down
Loading