fix: calculate contrast for translucent backgrounds using heuristic to prevent crashes#309
Merged
naveensingh merged 3 commits intoFossifyOrg:mainfrom Feb 13, 2026
Conversation
…ing a generalized heuristic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, I'm sorry I introduced a bug with my previous PR.
Type of change(s)
What changed and why
The previous PR changed the way the better contrasting color is calculated. However this didn't work for translucent backgrounds. The code would throw an InvalidArgumentException.
This PR fixes that by reverting to a heuristic to calculate the better contrasting color for translucent backgrounds. It uses a similar approach to the old code, but instead of depending on a hard coded threshold for DARK_GREY and WHITE, this code determines a threshold based on the relative luminance of any two colors calculated based on the WCAG standard (https://www.w3.org/WAI/WCAG22/Techniques/general/G17#procedure)
Tests performed
Tested it with the Calendar Widget, which was crashing after the last PR was applied and it did work again after this PR.
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).