Fixes #49: Upgrade to new Storage API's #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the message envelope used to wrap queue data with metadata (correlation id, properties) in the Azure Storage Queue implementation. Azure Storage Queue only supports a message body, and the envelope was previously used to support CorrelationId and Properties. However, this approach breaks backward compatibility with existing messages. This commit prioritizes backward compatibility by directly serializing and deserializing the message body. As a result, CorrelationId and Properties from QueueEntryOptions are no longer persisted. Additionally, the tests that rely on the envelope functionality have been skipped.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| var blockBlob = container.GetBlockBlobReference("EmptyFolder/"); | ||
| await blockBlob.UploadFromStreamAsync(new MemoryStream(), null, null, null); | ||
| var blobClient = container.GetBlobClient("EmptyFolder/"); | ||
| await blobClient.UploadAsync(new MemoryStream()); |
|
|
||
| var blockBlob = container.GetBlockBlobReference("EmptyFolder/"); | ||
| await blockBlob.UploadFromStreamAsync(new MemoryStream(), null, null, null); | ||
| var blobClient = container.GetBlobClient("EmptyFolder/"); |
| await newBlob.StartCopyAsync(oldBlob, cancellationToken).AnyContext(); | ||
| while (newBlob.CopyState.Status == CopyStatus.Pending) | ||
| await _timeProvider.Delay(TimeSpan.FromMilliseconds(50), cancellationToken).AnyContext(); | ||
| var copyOperation = await targetBlob.StartCopyFromUriAsync(sourceBlob.Uri, cancellationToken: cancellationToken).AnyContext(); |
Comment on lines
+151
to
+155
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "Error saving {Path}: {Message}", normalizedPath, ex.Message); | ||
| return false; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be tested but local integration tests are passing. We need to see if any additional changes are needed to handle existing queued messages.