-
-
Notifications
You must be signed in to change notification settings - Fork 21
Add support for nested query and nested aggregation #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/nested-tests
Are you sure you want to change the base?
Add support for nested query and nested aggregation #145
Conversation
…neAggregationsVisitor; Fixed NestedAggregation_WithIncludeCommaSeparatedValues_FiltersCorrectly test of ElasticNestedQueryParserTests
…/Foundatio.Parsers into feature/nested-tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for nested query and nested aggregation functionality to the Elasticsearch query parser. The implementation enables handling of nested field aggregations and properly nesting them within the Elasticsearch aggregation structure.
- Enhanced the
CombineAggregationsVisitor
to detect and handle nested field aggregations automatically - Modified the
SearchDescriptorExtensions
to properly copy nested aggregations and their inner structure - Updated test cases to verify exclusion filters work correctly for nested field aggregations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
CombineAggregationsVisitor.cs |
Added logic to detect nested fields and wrap them in nested aggregations with proper structure |
SearchDescriptorExtensions.cs |
Implemented recursive aggregation copying to handle nested aggregations and their metadata |
ElasticNestedQueryParserTests.cs |
Updated test to verify multiple nested field aggregations with exclusion filters |
src/Foundatio.Parsers.ElasticQueries/Visitors/CombineAggregationsVisitor.cs
Outdated
Show resolved
Hide resolved
src/Foundatio.Parsers.ElasticQueries/Visitors/CombineAggregationsVisitor.cs
Outdated
Show resolved
Hide resolved
src/Foundatio.Parsers.ElasticQueries/Extensions/SearchDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
src/Foundatio.Parsers.ElasticQueries/Extensions/SearchDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
…egation_HandlesNestedContextCorrectly
…atedValues_FiltersCorrectly
…to fix nested query parser tests
No description provided.