Skip to content

Conversation

veeraagandhi
Copy link

No description provided.

…neAggregationsVisitor; Fixed NestedAggregation_WithIncludeCommaSeparatedValues_FiltersCorrectly test of ElasticNestedQueryParserTests
@CLAassistant
Copy link

CLAassistant commented Jul 31, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@niemyjski niemyjski requested a review from Copilot July 31, 2025 20:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for nested query and nested aggregation functionality to the Elasticsearch query parser. The implementation enables handling of nested field aggregations and properly nesting them within the Elasticsearch aggregation structure.

  • Enhanced the CombineAggregationsVisitor to detect and handle nested field aggregations automatically
  • Modified the SearchDescriptorExtensions to properly copy nested aggregations and their inner structure
  • Updated test cases to verify exclusion filters work correctly for nested field aggregations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
CombineAggregationsVisitor.cs Added logic to detect nested fields and wrap them in nested aggregations with proper structure
SearchDescriptorExtensions.cs Implemented recursive aggregation copying to handle nested aggregations and their metadata
ElasticNestedQueryParserTests.cs Updated test to verify multiple nested field aggregations with exclusion filters

@veeraagandhi veeraagandhi marked this pull request as ready for review August 4, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants