Skip to content

Adds nested field tests #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Adds nested field tests #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ecb6e7d
Adds nested field support in tests
niemyjski Jul 18, 2025
717a490
formatting updates
niemyjski Jul 18, 2025
479153c
Adds nested aggregations filtering tests
niemyjski Jul 18, 2025
d28f22b
Merge branch 'main' into feature/nested-tests
niemyjski Jul 21, 2025
75f2996
Merge branch 'main' into feature/nested-tests
niemyjski Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions tests/Foundatio.Repositories.Elasticsearch.Tests/AggregationQueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System.Linq;
using System.Threading.Tasks;
using Exceptionless.DateTimeExtensions;
using Foundatio.Repositories.Elasticsearch.Extensions;
using Foundatio.Repositories.Elasticsearch.Tests.Repositories.Models;
using Foundatio.Repositories.Models;
using Microsoft.Extensions.Time.Testing;
Expand Down Expand Up @@ -106,47 +105,6 @@ await _employeeRepository.AddAsync(new Employee
Assert.Equal(1, result.Aggregations.Cardinality("cardinality_twitter").Value);
}

[Fact]
public async Task GetNestedAggregationsAsync()
{
var utcToday = new DateTimeOffset(DateTime.UtcNow.Year, 1, 1, 12, 0, 0, TimeSpan.FromHours(5));
var employees = new List<Employee> {
EmployeeGenerator.Generate(nextReview: utcToday.SubtractDays(2)),
EmployeeGenerator.Generate(nextReview: utcToday.SubtractDays(1))
};
employees[0].Id = "employee1";
employees[0].Id = "employee2";
employees[0].PeerReviews = new PeerReview[] { new PeerReview { ReviewerEmployeeId = employees[1].Id, Rating = 4 } };
employees[1].PeerReviews = new PeerReview[] { new PeerReview { ReviewerEmployeeId = employees[0].Id, Rating = 5 } };

await _employeeRepository.AddAsync(employees, o => o.ImmediateConsistency());

var nestedAggQuery = _client.Search<Employee>(d => d.Index("employees").Aggregations(a => a
.Nested("nested_reviewRating", h => h.Path("peerReviews")
.Aggregations(a1 => a1.Terms("terms_rating", t => t.Field("peerReviews.rating").Meta(m => m.Add("@field_type", "integer")))))
));

var result = nestedAggQuery.Aggregations.ToAggregations();
Assert.Single(result);
Assert.Equal(2, ((result["nested_reviewRating"] as Foundatio.Repositories.Models.SingleBucketAggregate).Aggregations["terms_rating"] as Foundatio.Repositories.Models.BucketAggregate).Items.Count);

var nestedAggQueryWithFilter = _client.Search<Employee>(d => d.Index("employees").Aggregations(a => a
.Nested("nested_reviewRating", h => h.Path("peerReviews")
.Aggregations(a1 => a1
.Filter("user_" + employees[0].Id, f => f.Filter(q => q.Term(t => t.Field("peerReviews.reviewerEmployeeId").Value(employees[0].Id)))
.Aggregations(a2 => a2.Terms("terms_rating", t => t.Field("peerReviews.rating").Meta(m => m.Add("@field_type", "integer")))))
))));

result = nestedAggQueryWithFilter.Aggregations.ToAggregations();
Assert.Single(result);

var filteredAgg = ((result["nested_reviewRating"] as Foundatio.Repositories.Models.SingleBucketAggregate).Aggregations["user_" + employees[0].Id] as Foundatio.Repositories.Models.SingleBucketAggregate);
Assert.NotNull(filteredAgg);
Assert.Single(filteredAgg.Aggregations.Terms("terms_rating").Buckets);
Assert.Equal("5", filteredAgg.Aggregations.Terms("terms_rating").Buckets.First().Key);
Assert.Equal(1, filteredAgg.Aggregations.Terms("terms_rating").Buckets.First().Total);
}

[Fact]
public async Task GetAliasedNumberAggregationThatCausesMappingAsync()
{
Expand Down
Loading
Loading