Skip to content

Fix InvalidCastException in InMemoryCacheClient.GetAsync<object>() for non-IConvertible types #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejsmith merged 3 commits into from
Mar 1, 2026
Merged

Fix InvalidCastException in InMemoryCacheClient.GetAsync<object>() for non-IConvertible types #468

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6429ac8
Initial plan
Copilot Mar 1, 2026
35f8bcf
Fix InvalidCastException in GetValue<object>() for non-IConvertible t…
Copilot Mar 1, 2026
c6d24a3
Extend test to cover CloneValues=true scenario
Copilot Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Foundatio/Caching/InMemoryCacheClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,7 +1767,7 @@ public T GetValue<T>()
object val = Value;
var t = typeof(T);

if (t == TypeHelper.BoolType || t == TypeHelper.StringType || t == TypeHelper.CharType || t == TypeHelper.DateTimeType || t == TypeHelper.ObjectType || t.IsNumeric())
if (t == TypeHelper.BoolType || t == TypeHelper.StringType || t == TypeHelper.CharType || t == TypeHelper.DateTimeType || t.IsNumeric())
return (T)Convert.ChangeType(val, t);

if (t == TypeHelper.NullableBoolType || t == TypeHelper.NullableCharType || t == TypeHelper.NullableDateTimeType || t.IsNullableNumeric())
Expand Down
17 changes: 17 additions & 0 deletions tests/Foundatio.Tests/Caching/InMemoryCacheClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,6 +1596,23 @@ public async Task DoMaintenanceAsync_WithPositiveTimezoneOffset_ShouldNotThrowOn
Assert.Null(Log.LogEntries.SingleOrDefault(l => l.LogLevel == LogLevel.Error));
}
}

[Fact]
public async Task GetAsync_WithObjectType_ReturnsValueDirectly()
{
var cache = new InMemoryCacheClient(o => o.LoggerFactory(Log));
using (cache)
{
var data = new MyData("hello", 42);
await cache.SetAsync("key", data);

var result = await cache.GetAsync<object>("key");
Assert.True(result.HasValue);
Assert.Equal(data, result.Value);
}
}

private record MyData(string Name, int Value);
}

/// <summary>
Expand Down