Add BIP-352 Silent Payment send support#634
Draft
qwldcl-del wants to merge 17 commits intoFoundation-Devices:mainfrom
Draft
Add BIP-352 Silent Payment send support#634qwldcl-del wants to merge 17 commits intoFoundation-Devices:mainfrom
qwldcl-del wants to merge 17 commits intoFoundation-Devices:mainfrom
Conversation
* Dockerfile: Update base image to Ubuntu 24.04 (Noble Numbat). * .github/workflows/build.yaml: Likewise.
* .github/workflows/build.yaml: Increase MSRV to 1.77.1. * .github/workflows/lint.yaml: Likewise. * Dockerfile: Likewise.
* .github/workflows/build.yaml: Upload ELF file with debugging information. * ports/stm32/Makefile (CFLAGS): Add -g flag.
* .github/workflows/lint.yaml (is-reuse-compliant): Bump fsfe/reuse-action to v4.
* .github/workflows/build.yaml: Bump docker/build-push-action from 5 to 6.
Changes made using: ``` rg 'hello@foundationdevices\.com' --files-with-matches | xargs sed -i 's/hello@foundationdevices\.com/hello@foundation.xyz/g' ```
…deprecation message in reuse lint
* extmod/foundation-rust/Cargo.toml (profile) <release>: Don't strip debug information.
…-6727-fix-github-actions SFT-6727: fix GitHub actions
…-3235-re-enable-btcpay-taproot SFT-3235: re-enable btcpay taproot
- Add silent_payments.py module with functions for: - Decoding Silent Payment addresses (sp1.../tsp1...) - Encoding Silent Payment addresses - Address type detection - Update chains.py to import Silent Payment functions This implements basic Silent Payment address support as required for the bounty: Foundation-Devices#527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR to upstream