Modify Backup URL in Reconciler #2347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millasml
force-pushed
the
millas/reconcile-backup-name
branch
from
bf52919 to
c47d696
Compare
johscheuer
reviewed
Aug 14, 2025
| @@ -322,6 +322,11 @@ func (backup *FoundationDBBackup) CheckReconciliation() (bool, error) { | |||
| reconciled = false | |||
| } | |||
|
|
|||
| if isRunning && backup.BackupURL() != backup.Status.BackupDetails.URL { | |||
There was a problem hiding this comment.
I think it would be better to create a dedicated method (e.g. NeedsConfigurationChange) for this and combine the SnapshotPeriodSeconds and URL check. That way the method can be extended in the future without adding more if statements in CheckReconciliation.
added 3 commits
August 25, 2025 11:48
millasml
force-pushed
the
millas/reconcile-backup-name
branch
from
c47d696 to
b543387
Compare
added 3 commits
August 25, 2025 12:16
|
@johscheuer updated this! |
johscheuer
requested changes
Sep 1, 2025
Comment on lines
+44
to
+49
| snapshotPeriod := backup.SnapshotPeriodSeconds() | ||
| backupURL := backup.BackupURL() | ||
|
|
||
| shouldModify := backup.Status.BackupDetails.SnapshotPeriodSeconds != snapshotPeriod || | ||
| backup.Status.BackupDetails.URL != backupURL | ||
| if shouldModify { |
There was a problem hiding this comment.
Suggested change
| snapshotPeriod := backup.SnapshotPeriodSeconds() | |
| backupURL := backup.BackupURL() | |
| shouldModify := backup.Status.BackupDetails.SnapshotPeriodSeconds != snapshotPeriod || | |
| backup.Status.BackupDetails.URL != backupURL | |
| if shouldModify { | |
| if backup.NeedsBackupReconfiguration() { |
Right now we are doing the same checks in NeedsBackupReconfiguration() , so is there a reason not to make use of it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is addressed. If this change resolves an issue, please include the issue number in the description.
Type of change
Please select one of the options below.
Discussion
Are there any design details that you would like to discuss further?
Testing
Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
Documentation
Did you update relevant documentation within this repository?
If this change is adding new functionality, do we need to describe it in our user manual?
If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?
If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?
Follow-up
Are there any follow-up issues that we should pursue in the future?
Does this introduce new defaults that we should re-evaluate in the future?