-
Notifications
You must be signed in to change notification settings - Fork 111
Support isDistinctFrom and isNotDistinctFrom operators #3357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+879
−46
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
abf60b7
not distinct from
pengpeng-lu fc8bbde
is distinct from
pengpeng-lu bdedab9
fix test
pengpeng-lu 360d238
pmd
pengpeng-lu db1f740
add index matching test
pengpeng-lu a7570ab
merge main
pengpeng-lu 7c0b283
parser
pengpeng-lu 6e540c1
remove standard test
pengpeng-lu 3c537c1
remove
pengpeng-lu 1daf249
save
pengpeng-lu b93b544
remove over optimization
pengpeng-lu 35b081c
toClassWithRealEquals take nonnull input
pengpeng-lu 70aa7e6
comparisons methods
pengpeng-lu 3a8c3dc
checkstyle
pengpeng-lu b134bbb
Merge branch 'main' into distinct_from
pengpeng-lu 0c45afe
fix compareLike
pengpeng-lu 6af3ef8
Merge branch 'main' into distinct_from
pengpeng-lu 6b82cb2
add booleanValueTest
pengpeng-lu 2eb1075
rename operators
pengpeng-lu dd7538f
Merge branch 'main' into distinct_from
pengpeng-lu ded9003
Merge branch 'main' into distinct_from
pengpeng-lu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is interesting that we have this early treatment of
null
values here instead of delegating it to the actual underlying physical operator.I opened an issue to fix this, as well as introducing
NULL
type code handling (instead of the deprecatedUNKNOWN
).#3526
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I'm not sure about this as well, but putting it in the operators will result in a lot of duplicated code. Fixing it in a separate PR sounds good.