HNSW poc #3516
Open
HNSW poc #3516
+7,023
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMcM
requested changes
Aug 1, 2025
| * @return a {@link String} containing the hexadecimal representation of the byte array passed in | ||
| */ | ||
| @Nonnull | ||
| static String bytesToHex(byte[] bytes) { |
There was a problem hiding this comment.
Can this be shared with the NodeHelpers one?
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * NodeHelpers.java | |||
| * HNSWHelpers.java | |||
| @@ -24,7 +24,7 @@ package com.apple.foundationdb.record.evolution.fieldtypechange; | |||
| option java_package = "com.apple.foundationdb.record.evolution"; | |||
| option java_outer_classname = "TestFieldTypeChangeProto"; | |||
|
|
|||
| import "record_metadata_options.proto"; | |||
| //import "record_metadata_options.proto"; | |||
There was a problem hiding this comment.
Not sure what happened. I changed something somewhere in a test proto file and suddenly got all these warnings about unnecessary imports. And since we run everything in -Werror...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.