Handle metrics for the same query but with different setups #3531
+181
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planner metrics previously assumed that it was only reasonable to have a query once within a single block. Having setup can make this more complicated, so this changes the keys for the metrics to have the setup too. There were a couple unrelated cleanups along the way: 1. `markDirty()` was annotated `@Nullable`, but is `void` 2. `putMetrics` took `isDirectyMetrics`, but that parameter was never used, so I removed it.
normen662
reviewed
Aug 8, 2025
yaml-tests/src/main/java/com/apple/foundationdb/relational/yamltests/YamlExecutionContext.java
Outdated
Show resolved
Hide resolved
yaml-tests/src/main/java/com/apple/foundationdb/relational/yamltests/YamlExecutionContext.java
Show resolved
Hide resolved
normen662
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planner metrics previously assumed that it was only reasonable to have a query once within a single block. Having setup can make this more complicated, so this changes the keys for the metrics to have the setup too.
There were a couple unrelated cleanups along the way:
markDirty()was annotated@Nullable, but isvoidputMetricstookisDirectyMetrics, but that parameter was never used, so I removed it.