Add more prefix-based tests to like.yamsql #3536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional set of tests to
like.yamsql
that are designed to handle prefix scans where the prefix can be satisfied by an index. Our logic currently doesn't handle transformingLIKE '${str}%'
into a tuple scan with a range like[PREFIX_STRING ${str}]
, which means that we don't use the index as efficiently as we could. This is shown in theexplain
s here, where we only use the index in order to get a set of covering fields, but we don't add it to a scan range.Note that this is relevant to #3523 (addressing #1076), as if we did turn those kinds of
LIKE
expressions into prefix string scans, we'd get mixed-mode coverage of the fix for the bug being addressed there. AFAIK, there isn't any other SQL comparison that we have that we could use to generate prefix string scans in some other way.