[WIP] Download email/folder, using .eml format - Community#325
#2422
Conversation
An option is available in the reply drop-down called "Download Email", clicking this will prompt the user for the output directory
|
This pull request has been mentioned on Mailspring Community. There might be relevant details there: https://community.getmailspring.com/t/export-copy-backup-emails/325/17 |
glenn2223
changed the title
.eml format - Community#325.eml format - Community#325
A few changes: - Right clicking on a folder (excluding Drafts, Unread, Starred) gives an option to "Export the %@ folder" - In order to get this to work I needed to add the property/reference to the existing DB column `remoteFolderId` - Sanitise regex utilities for paths - Downloading a single email now has it's name sanitised to stop saving errors (i.e slashes, colons, etc.) - Prettier/lint changes (for best practices) **Issues:** - Needs translations - long running process ties up mailsync - need to deprioritise tasks or have a `Action.queueBackgroundTask` option
glenn2223
changed the title
.eml format - Community#325.eml format - Community#325
glenn2223
changed the title
.eml format - Community#325.eml format - Community#325
|
This pull request has been mentioned on Mailspring Community. There might be relevant details there: https://community.getmailspring.com/t/export-copy-backup-emails/325/18 |
glenn2223
changed the title
.eml format - Community#325.eml format - Community#325
|
Hey hey - this looks great! I think you're right that mailsync needs a mechanism for background tasks, and we likely need just one background task to represent the "export folder" operation so that it's easy to cancel + attach progress. I'm a bit worried that queueing tons and tons of individual tasks might cause problems. I like the idea of adding a "priority" value to tasks and then sorting by priority when mailsync retrieves a task to run. Maybe something like that would work? |
YES PLEASE!!!!!!!!!!!!!!!! 😂 And I agree, there wouldn't be an easy way of cancelling these tasks - if the user decided to
That was my other choice and that would definitely work. PS: sorry if there's any shoddy code. Full discretion, I have almost no experience with React and Electron 😁 |
bengotow
force-pushed
the
master
branch
2 times, most recently
from
e0bdee2 to
de5e87e
Compare
bengotow
force-pushed
the
master
branch
5 times, most recently
from
77d1cc7 to
e2e0f88
Compare
bengotow
force-pushed
the
master
branch
9 times, most recently
from
bfa5e25 to
b378ba0
Compare
bengotow
force-pushed
the
master
branch
17 times, most recently
from
610fb16 to
1a8284d
Compare
bengotow
force-pushed
the
master
branch
2 times, most recently
from
0453e6a to
13dc018
Compare
3 participants
Work towards Export/Copy/Backup Emails
This pull request is the first (hopefully of many 😁) towards
.emlsupport.This PR provides:
Need
Approval for the image, or leave it as is (no image) - if you want the image, how do I add it (linking it doesn't work)
Can I have thoughts on sub-folders? Do we just recurse over them and create the subdirectories by default, maybe have an extra option to say "Export just this folder"?
Help
The issue: I started to export almost 1500 emails, then clicked on one, it was only after all 1500 downloaded that the email was rendered.
Possible solution: I need to be able to deprioritise a task, when it's sent to mailsync, or have a new action, something like
Action.queueBackgroundTasks. Either way, this would sit these tasks at the sideline while the other (more important) tasks come through.