Skip to content

Commit 48ff2bd

Browse files
committed
minor symfony#20409 [SecurityBundle] Make the FirewallConfig class final (ogizanagi)
This PR was merged into the 3.2-dev branch. Discussion ---------- [SecurityBundle] Make the FirewallConfig class final | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A I suggest to make the `FirewallConfig` class final. This value object is only built by the `SecurityExtension` from the `SecurityBundle` and is not meant to be an extension point. ping @chalasr Commits ------- 5963627 [SecurityBundle] Make the FirewallConfig class final
2 parents 706d925 + 5963627 commit 48ff2bd

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/Symfony/Bundle/SecurityBundle/Security/FirewallConfig.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
/**
1515
* @author Robin Chalas <[email protected]>
1616
*/
17-
class FirewallConfig
17+
final class FirewallConfig
1818
{
1919
private $name;
2020
private $requestMatcher;

src/Symfony/Bundle/SecurityBundle/Tests/Security/FirewallContextTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ class FirewallContextTest extends \PHPUnit_Framework_TestCase
2020
{
2121
public function testGetters()
2222
{
23-
$config = $this
24-
->getMockBuilder(FirewallConfig::class)
25-
->disableOriginalConstructor()
26-
->getMock();
23+
$config = new FirewallConfig('main', 'request_matcher');
2724

2825
$exceptionListener = $this
2926
->getMockBuilder(ExceptionListener::class)

0 commit comments

Comments
 (0)